> -----Original Message-----
> From: Ilya Maximets <[email protected]>
> Sent: Thursday, February 28, 2019 11:59 AM
> To: Ophir Munk <[email protected]>; [email protected]
> Cc: Asaf Penso <[email protected]>; Ian Stokes <[email protected]>;
> Shahaf Shuler <[email protected]>; Olga Shern
> <[email protected]>; Kevin Traynor <[email protected]>; Roni Bar
> Yanai <[email protected]>
> Subject: Re: [PATCH v3 2/3] netdev-dpdk: Move offloading code to a new file
>
> On 28.02.2019 12:44, Ophir Munk wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ilya Maximets <[email protected]>
> >> Sent: Thursday, February 28, 2019 10:25 AM
> >> To: Ophir Munk <[email protected]>; [email protected]
> >> Cc: Asaf Penso <[email protected]>; Ian Stokes
> >> <[email protected]>; Shahaf Shuler <[email protected]>; Olga
> >> Shern <[email protected]>; Kevin Traynor <[email protected]>;
> Roni
> >> Bar Yanai <[email protected]>
> >> Subject: Re: [PATCH v3 2/3] netdev-dpdk: Move offloading code to a
> >> new file
> >>
> >> On 28.02.2019 1:37, Ophir Munk wrote:
> >>> From: Roni Bar Yanai <[email protected]>
> >>>
> >>> Hardware offloading code is moved to a new file called
> >>> netdev-rte-offloads.c. The original offloading code is copied from
> >>> the netdev-dpdk.c file to the new file, where future offloading code
> >>> should be added as well.
> >>> The copied code was refactored based on coding style.
> >>> The netdev-dpdk.c file will remain unchanged as new offloading code
> >>> is added.
> >>>
> >>> Co-authored-by: Ophir Munk <[email protected]>
> >>> Reviewed-by: Asaf Penso <[email protected]>
> >>> Signed-off-by: Roni Bar Yanai <[email protected]>
> >>> Signed-off-by: Ophir Munk <[email protected]>
> >>> ---
> >>> lib/automake.mk | 4 +-
> >>> lib/netdev-dpdk.c | 727
> >>> +------------------------------------------
> >>> lib/netdev-rte-offloads.c | 776
> >> ++++++++++++++++++++++++++++++++++++++++++++++
> >>> lib/netdev-rte-offloads.h | 39 +++
> >>> 4 files changed, 819 insertions(+), 727 deletions(-) create mode
> >>> 100644 lib/netdev-rte-offloads.c create mode 100644
> >>> lib/netdev-rte-offloads.h
> >>>
> >>> diff --git a/lib/automake.mk b/lib/automake.mk index
> >>> bae032b..cc5dccf 100644
> >>> --- a/lib/automake.mk
> >>> +++ b/lib/automake.mk
> >>> @@ -138,6 +138,7 @@ lib_libopenvswitch_la_SOURCES = \
> >>> lib/netdev-dpdk.h \
> >>> lib/netdev-dummy.c \
> >>> lib/netdev-provider.h \
> >>> + lib/netdev-rte-offloads.h \
> >>> lib/netdev-vport.c \
> >>> lib/netdev-vport.h \
> >>> lib/netdev-vport-private.h \
> >>> @@ -411,7 +412,8 @@ endif
> >>> if DPDK_NETDEV
> >>> lib_libopenvswitch_la_SOURCES += \
> >>> lib/dpdk.c \
> >>> - lib/netdev-dpdk.c
> >>> + lib/netdev-dpdk.c \
> >>> + lib/netdev-rte-offloads.c
> >>> else
> >>> lib_libopenvswitch_la_SOURCES += \
> >>> lib/dpdk-stub.c
> >>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index
> >>> 57f9c25..3029ec0 100644
> >>> --- a/lib/netdev-dpdk.c
> >>> +++ b/lib/netdev-dpdk.c
> >>> @@ -47,6 +47,7 @@
> >>> #include "dpif-netdev.h"
> >>> #include "fatal-signal.h"
> >>> #include "netdev-provider.h"
> >>> +#include "netdev-rte-offloads.h"
> >>> #include "netdev-vport.h"
> >>> #include "odp-util.h"
> >>> #include "openvswitch/dynamic-string.h"
> >>> @@ -179,17 +180,6 @@ static const struct rte_eth_conf port_conf = {
> >>> };
> > ...
> >>> --- /dev/null
> >>> +++ b/lib/netdev-rte-offloads.c
> >>> @@ -0,0 +1,776 @@
> >>> +/*
...
> >>> +/*
> >>> + * Check if any unsupported flow patterns are specified.
> >>> + */
> >>> +static int
> >>> +netdev_dpdk_validate_flow(const struct match *match)
> >>
> >> Hmm. This function doesn't look like it was in netdev-dpdk.c.
> >>
> >
> > Can you please double check?
> > I see it in netdev-dpdk.c (before the patch series).
>
> Sorry for being unclear. I didn't mean that there are no such function.
> I meant that it was refactored by the following patch:
>
> 6ebc4b09c2bb ("netdev-dpdk: Flow validation refactoring.")
>
> But after moving it to the new file most of the changes made by above patch
> disappeared. Just compare the function that you're removing with the
> function you're adding.
>
> >
Fixed in v5
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
