On Sat, Mar 02, 2019 at 12:14:02PM +0000, Nitin Katiyar wrote:
> Hi,
> 
> > -----Original Message-----
> > From: Ben Pfaff [mailto:[email protected]]
> > Sent: Saturday, March 02, 2019 12:15 AM
> > To: Nitin Katiyar <[email protected]>
> > Cc: [email protected]; Manohar Krishnappa Chidambaraswamy
> > <[email protected]>
> > Subject: Re: [ovs-dev] [PATCH v4 2/2] Avoid packet drop on LACP bond after
> > link up
> > 
> > I don't entirely understand the problem.  It seems like a driver bug.
> > Why isn't the bug being fixed?
> I agree it is driver/firmware bug but OVS implementation also doesn't account 
> for link state which causes traffic drop in case of bond.

OK.

Could you update the commit message to make it clear that there's an OVS
problem instead of just a NIC driver problem?  When I look at it as a
NIC driver problem only, I'm less inclined to take the fix, but if it's
a problem in OVS then of course we'll fix it.

> > Patches 1 and 2 have the same title.  It would be better if they were 
> > different.
> Both issues had surfaced in same scenario so we decided to have 2 patches. 
> But we can send it as 2 different patches next time.

It's fine as two patches, I just want their subjects to be different.
Otherwise references to them post-commit will be ambiguous unless the
git commit number matches (which can't always be the case).
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to