In case of reconfiguration while 'vhost_id' is not set yet,
there will be the meaningless message like:
|netdev_dpdk|DBG|TX queue mapping for
|netdev_dpdk|DBG| 0 --> 0
It's better to print the name of the netdev which is always set.
Additionally fixed possible splitting by other log messages and
missing space in the queue state message.
Signed-off-by: Ilya Maximets <[email protected]>
---
lib/netdev-dpdk.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 4f9ca3b3a..93d8e37bb 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -3451,9 +3451,17 @@ netdev_dpdk_remap_txqs(struct netdev_dpdk *dev)
}
}
- VLOG_DBG("TX queue mapping for %s\n", dev->vhost_id);
- for (i = 0; i < total_txqs; i++) {
- VLOG_DBG("%2d --> %2d", i, dev->tx_q[i].map);
+ if (VLOG_IS_DBG_ENABLED()) {
+ struct ds mapping = DS_EMPTY_INITIALIZER;
+
+ ds_put_format(&mapping, "TX queue mapping for port '%s':\n",
+ netdev_get_name(&dev->up));
+ for (i = 0; i < total_txqs; i++) {
+ ds_put_format(&mapping, "%2d --> %2d\n", i, dev->tx_q[i].map);
+ }
+
+ VLOG_DBG("%s", ds_cstr(&mapping));
+ ds_destroy(&mapping);
}
free(enabled_queues);
@@ -3621,7 +3629,7 @@ vring_state_changed(int vid, uint16_t queue_id, int
enable)
ovs_mutex_unlock(&dpdk_mutex);
if (exists) {
- VLOG_INFO("State of queue %d ( tx_qid %d ) of vhost device '%s'"
+ VLOG_INFO("State of queue %d ( tx_qid %d ) of vhost device '%s' "
"changed to \'%s\'", queue_id, qid, ifname,
(enable == 1) ? "enabled" : "disabled");
} else {
--
2.17.1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
