Aaron Conole <acon...@bytheb.org> writes:
> Nitin Katiyar <nitin.kati...@ericsson.com> writes:
>
>> Hi,
>> I got this mail reporting build failure. It complains for bond
>> variable not being used. I had sent patch earlier after correcting
>> this. So, I am not sure which patch version it is complaining for. In
>> my latest patch I see that it is being used. Am I missing something?
>
> Looking at the message ID to which you're replying:
>
> Robot mail: 1551257882-9544-1-git-send-email-ro...@bytheb.org
>
> Looking at that message id, it is a reply to:
>
> Nitin Katiyar: 1551285539-31225-1-git-send-email-nitin.kati...@ericsson.com
>
> Looking at that message, I see that it includes:
>
> @@ -324,8 +325,8 @@ lacp_is_active(const struct lacp *lacp)
> OVS_EXCLUDED(mutex)
> /* Processes 'packet' which was received on 'slave_'. This function should
> be
> * called on all packets received on 'slave_' with Ethernet Type
> ETH_TYPE_LACP.
> */
> -void
> -lacp_process_packet(struct lacp *lacp, const void *slave_,
> +bool
> +lacp_process_packet(struct lacp *lacp, const void *bond, const void *slave_,
> const struct dp_packet *packet)
> OVS_EXCLUDED(mutex)
> {
>
>
> Which indeed looks like the bond argument is added, but never referenced.
>
>> On other hand, it will be good if report captures the patch or version of
>> the patch.
>
> I agree, I'll fix that up.
Just following up. This should be fixed now.
> On the other hand, the email in question is at url:
>
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356740.html
>
> It does not contain a version string. So it seems this is a valid
> report.
>
>> Regards,
>> Nitin
>>
>> -----Original Message-----
>> From: 0-day Robot [mailto:ro...@bytheb.org]
>> Sent: Wednesday, February 27, 2019 2:28 PM
>> To: Nitin Katiyar <nitin.kati...@ericsson.com>
>> Cc: d...@openvswitch.org
>> Subject: Re: Avoid packet drop on LACP bond after link up
>>
>> Bleep bloop. Greetings Nitin Katiyar, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> build:
>> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib
>> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/jhash.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/jhash.lo lib/jhash.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/jhash.lo -MD -MP -MF lib/.deps/jhash.Tpo -c
>> lib/jhash.c -o lib/jhash.o depbase=`echo lib/json.lo | sed
>> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib
>> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/json.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/json.lo lib/json.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/json.lo -MD -MP -MF lib/.deps/json.Tpo -c
>> lib/json.c -o lib/json.o depbase=`echo lib/jsonrpc.lo | sed
>> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib
>> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/jsonrpc.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/jsonrpc.lo lib/jsonrpc.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/jsonrpc.lo -MD -MP -MF lib/.deps/jsonrpc.Tpo -c
>> lib/jsonrpc.c -o lib/jsonrpc.o depbase=`echo lib/lacp.lo | sed
>> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib
>> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/lacp.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/lacp.lo lib/lacp.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
>> -Werror -g -O2 -MT lib/lacp.lo -MD -MP -MF lib/.deps/lacp.Tpo -c
>> lib/lacp.c -o lib/lacp.o
>> lib/lacp.c: In function 'lacp_process_packet':
>> lib/lacp.c:329:52: error: unused parameter 'bond'
>> [-Werror=unused-parameter] lacp_process_packet(struct lacp *lacp,
>> const void *bond, const void *slave_,
>> ^
>> cc1: all warnings being treated as errors
>> make[2]: *** [lib/lacp.lo] Error 1
>> make[2]: Leaving directory
>> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory
>> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
>> make: *** [all] Error 2
>>
>>
>> Please check this out. If you feel there has been an error, please email
>> acon...@bytheb.org
>>
>> Thanks,
>> 0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
