On 06.03.2019 18:15, Michael Santana Francisco wrote:
> On 3/6/19 2:57 AM, Ilya Maximets wrote:
>> On 06.03.2019 0:01, Michael Santana Francisco wrote:
>>> On 3/5/19 3:30 PM, Aaron Conole wrote:
>>>> Ilya Maximets <i.maxim...@samsung.com> writes:
>>>>
>>>>> Python scripts appeared only since OVS 2.9.
>>>>> This fixes unit test 'monitor-cond-change with many sessions pending'.
>>>>> Issue appered while backporting the following patch:
>>>>> e0f42d4a6548 ("monitor: Fix crash when monitor condition adds new
>>>>> columns.")
>>>>>
>>>>> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
>>>>> ---
>>>> Acked-by: Aaron Conole <acon...@redhat.com>
>>>> _______________________________________________
>>>> dev mailing list
>>>> d...@openvswitch.org
>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>> Hi Ilya,
>> Hi Michael.
>>
>>> So funny story, I was working on fixing this exact same issue on 2.7 and
>>> 2.8, but I had not yet seen your patch until a couple of minutes ago. I
>>> made the same exact fix you made, tested it, made a patch, I was getting
>>> ready to submit the patch, then I saw your patch and realized you already
>>> submitted a fix for it. It works, thanks.
>> It happens from time to time for me too. Thanks for looking at the issue.
>>
>> BTW, as you're working with tests and CI on older branches, you may found
>> following patch-set interesting:
>> https://patchwork.ozlabs.org/project/openvswitch/list/?series=94247
> Interesting. What kind of performance benefits are you getting with rsyslog
> disabled?
If you'll look here:
https://travis-ci.org/openvswitch/ovs/branches
You'll see that builds for branches <= 2.11 constantly fails due to
job timeouts (50 minutes). Disabling the syslog allows to finish
normal testsuite job in ~20 minutes.
> Also, doesn't the sudo: false in the .travis.yml file make it so that you
> can't use sudo in the script?
TravisCI migrated from containers to VMs few months ago, so 'sudo' is
always available now.
I'll clean this up. Thanks for spotting.
>> Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
