On 05.03.2019 15:47, Nitin Katiyar wrote:
> Problem:
> 
> ========
> On certain Fortville NICs it has been observed that PHY UP detection can
> get delayed (sometimes up to 4-5 secs). When the driver fails to fetch
> PHY status as UP even though its actually UP, LACP packets can get
> exchanged and LACP slave brought UP. In such a case, the remote end
> would start sending traffic on that slave, but OVS drops it, as the
> bond-slave is not yet enabled due to PHY DOWN.
> 
> Fix:
> ====
> The main intention here is delay LACP negotiation until carrier (PHY)
> status is read as UP.
> 
> 1. In port_run()/bundle_run(), cache the carrier status in
>   "struct ofport_dpif"/"struct bond_slave".
> 
> 2. When carrier state is DOWN, do not send any LACPDUs and
>   drop any received LACPDUs.
> 
> 3. When LACP state changes or LACPDU is received, trigger re-checking
>   of carrier-state (in port_run()) by incrementing the connectivity
>   sequence number to find out the true carrier state as fast as
>   possible.
> 
> Signed-off-by: Manohar Krishnappa Chidambaraswamy <[email protected]>
> Co-authored-by: Manohar Krishnappa Chidambaraswamy <[email protected]>
> Signed-off-by: Nitin Katiyar <[email protected]>
> ---

Hi.

This patch breaks the build with '--enable-shared':

  lib/.libs/libopenvswitch.so: undefined reference to `bond_slave_get_carrier'
  error: linker command failed with exit code 1 (use -v to see invocation)

For detailed logs see:
  https://travis-ci.org/ovsrobot/ovs/builds/502045221

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to