On Thu, Mar 07, 2019 at 04:15:20PM -0800, Han Zhou wrote: > On Thu, Mar 7, 2019 at 2:22 PM Ben Pfaff <[email protected]> wrote: > My apologies. It is caused by the first patch in this series. I can > reproduce easily by running idl tests such as: 2439: set, simple3 > idl-compound-index-with-ref, initially populated - C FAILED > (ovsdb-idl.at:1811) > > Not sure how I missed this in the first place. Probably I have run > irrelevant tests with "-k" and declared success. Anyways, stupid > mistake.
I do that sometimes too. > In fact the two patches in this series are independent. I ran test > with -k idl & -k ovn for patch 2/2 with & without address sanitizer, > and there is only one failure in ovn tests when running with address > sanitizer: > > 2745: ovn -- 1 LR with distributed router gateway port FAILED (ovn.at:8745) > > However, this fails even with master code. Without address sanitizer > it doesn't fail. Running tests with address sanitizer is much slower, > so it could be timing problem in test cases. So I should say the patch > 2/2 is ready for review. I do not get a failure with this test, running with (or presumably without) Address Sanitizer, so I agree that it is likely a timing issue. > I will figure out the problem of patch 1/2. OK. I will review patch 2. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
