> > because of: > > ./checkpatch.at:32: exit code was 0, expected 255 > > > > This patch introduces a positive constant for the default exit code. > > > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > > Acked-by: Ben Pfaff <[email protected]> > > Acked-by: Aaron Conole <[email protected]> > > I'm pretty sure that this is just for exit on failure, so probably EXIT_FAILURE > (or similar) would be a better name. [Alin Serdean] Updated here: https://patchwork.ozlabs.org/patch/1056056/ > > I'm not sure why we're using -1 (or 255). Most OVS utilities, and most Unix- > like software in general, use exit status 1 on failure. [Alin Serdean] TBH I just followed the exit code from: https://github.com/openvswitch/ovs/blob/master/tests/checkpatch.at#L33 > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
