'dpctl/help' command is not registered and could not be called. However, 'dpctl/list-commands' prints it as available.
CC: Ben Pfaff <[email protected]> Fixes: 337c45285445 ("dpctl: Fix jump through wild pointer in "dpctl/help".") Signed-off-by: Ilya Maximets <[email protected]> --- lib/dpctl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/dpctl.c b/lib/dpctl.c index baf37b8bc..edb753cb4 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1348,6 +1348,10 @@ dpctl_list_commands(int argc OVS_UNUSED, const char *argv[] OVS_UNUSED, for (; commands->name; commands++) { const struct dpctl_command *c = commands; + if (dpctl_p->is_appctl && !strcmp(c->name, "help")) { + continue; + } + ds_put_format(&ds, " %s%-23s %s\n", dpctl_p->is_appctl ? "dpctl/" : "", c->name, c->usage); } -- 2.17.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
