On Tue, Mar 12, 2019 at 10:00:02PM +0530, [email protected] wrote: > From: Numan Siddique <[email protected]> > > This series attempts to add a new thread in pinctrl module. This thread > will handle the packet-ins. > > v1 -> v2 > ------ > * Added a new patch p1 to the series suggessted by Mark. > * Addressed the review comments from Han and Mark.
Thanks for the series. Does this depend on some other series? I get a cascade of errors from Clang: ../ovn/controller/pinctrl.c:65:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:65:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:73:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:73:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:79:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:79:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:92:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:92:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:94:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:94:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:119:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:119:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.c:122:18: error: use of undeclared identifier 'pinctrl_mutex'; did you mean 'pinctrl_run'? ../include/openvswitch/compiler.h:124:45: note: expanded from macro 'OVS_REQUIRES' ../ovn/controller/pinctrl.h:34:6: note: 'pinctrl_run' declared here ../ovn/controller/pinctrl.c:122:5: error: 'exclusive_locks_required' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'void (struct ovsdb_idl_txn *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, struct ovsdb_idl_index *, const struct sbrec_dns_table *, const struct ovsrec_bridge *, const struct sbrec_chassis *, const struct hmap *, const struct sset *)' [-Werror,-Wthread-safety-attributes] ../include/openvswitch/compiler.h:124:20: note: expanded from macro 'OVS_REQUIRES' _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
