On 18/03/2019 23:58, Ben Pfaff wrote:
> On Sun, Mar 10, 2019 at 05:31:31AM +0000, Eli Britstein wrote:
>> Generate datapath ovs key fields offset and size array macros as a
>> pre-step for bit-wise comparing fields, with no functional change.
>>
>> Signed-off-by: Eli Britstein <[email protected]>
>> Reviewed-by: Roi Dayan <[email protected]>
>
> Thanks!
>
> This introduces a script that uses /bin/bash. I don't think that we
> have other build or runtime dependencies on bash, so it would be better
> to avoid introducing one here. I would rewrite it in terms of portable
> Bourne shell constructs.
>
Hi Ben,
just to clarify, when you see portable Bourne shell constructs,
you mean so it can work with other shells like dash on ubuntu?
There are other scripts depending on bash.
examples are tests in tests/system-traffic.at, the bash auto completion
scripts, ovs-sim.
do you still prefer us to be compatible and use /bin/sh shebang ?
Thanks,
Roi
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
