On Wed, Mar 27, 2019 at 10:54 AM Han Zhou <[email protected]> wrote:
> On Thu, Mar 14, 2019 at 12:33 PM <[email protected]> wrote:
> >
>
> > diff --git a/NEWS b/NEWS
> > index 89d0f19d6..74adb2562 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -24,6 +24,7 @@ Post-v2.11.0
> > protocol extension.
> > - OVN:
> > * Select IPAM mac_prefix in a random manner if not provided by the
> user
> > + * Added the HA chassis group support and deprecated Gateway
> chassis.
>
> I think we agreed that we will not deprecate Gateway chassis since it
> is more convenient in many cases. I guess it was carried over from v3.
>
Oops. My bad. I will correct it.
>
> > @@ -2195,18 +2191,27 @@ ovn_port_update_sbrec(struct northd_context *ctx,
> > if (op->derived) {
> > const char *redirect_chassis = smap_get(&op->nbrp->options,
> > "redirect-chassis");
> > - if (op->nbrp->n_gateway_chassis && redirect_chassis) {
> > + if (op->nbrp->ha_chassis_group &&
> op->nbrp->n_gateway_chassis) {
> > static struct vlog_rate_limit rl =
> VLOG_RATE_LIMIT_INIT(1, 1);
> > VLOG_WARN_RL(
> > - &rl, "logical router port %s has both options:"
> > - "redirect-chassis and gateway_chassis
> populated "
> > - "redirect-chassis will be ignored in favour of
> "
> > - "gateway chassis", op->nbrp->name);
> > + &rl, "logical router port %s has both:"
> > + "ha_chassis_group and gateway_chassis
> populated "
> > + "gateway_chassis will be ignored in favour of "
> > + "ha_chassis_group", op->nbrp->name);
>
> Now we have 3 ways to support port residing on gateway(s). This new
> warning only mentioned about ha_chassis_group v.s. gateway_chassis.
> Since redirect_chassis is still supported, it should still be warned
> if it is configured together with other methods.
>
Ack. Will add the warning.
Thanks
Numan
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
