Applied on master! > On 19 Mar 2019, at 00:43, Alin Gabriel Serdean <[email protected]> wrote: > > Using python `sys.exit(-1)` on Windows produces mixed results. > Let's take the following results from different shells: > CMD >> python -c "import sys; sys.exit(-1)" & echo %errorlevel% > 1 > MSYS > $ python -c "import sys; sys.exit(-1)" && echo $? > 0 > WSL > $ python -c "import sys; sys.exit(-1)"; echo $? > 255 > > this results in the following tests to fail: > checkpatch > > 10: checkpatch - sign-offs FAILED (checkpatch.at:32) > 11: checkpatch - parenthesized constructs FAILED (checkpatch.at:32) > 12: checkpatch - parenthesized constructs - for FAILED (checkpatch.at:32) > 13: checkpatch - comments FAILED (checkpatch.at:32) > > because of: > ./checkpatch.at:32: exit code was 0, expected 255 > > This patch introduces a positive constant for the default exit code (1) > similar to other OVS utilities. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > Acked-by: Ben Pfaff <[email protected]> > Acked-by: Aaron Conole <[email protected]>
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
