On Tue, Apr 16, 2019 at 11:58:08PM +0000, Ankur Sharma wrote:
> OVN allows only an integer (or masked integer) to be assigned to
> ct_mark and ct_label.
>
> This patch, enhances the parser code to allow ct_mark and ct_label
> to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128
> bit registers (MFF_XXREG0 - MFF_XXREG3) respectively.
>
> Signed-off-by: Ankur Sharma <[email protected]>
Thanks for the patch!
When we add new errors to the ovn action parser, we add tests to provoke
each of them. I don't see any new test for some of the errors here,
such as the "invalid token type" error.
We try to make the OVN action parser error messages grammatically
correct English sentences or phrases. For example:
Syntax error at `reg1' expecting integer
The new message
Syntax error at `xxreg1' input: xxreg1, not a 32 bit register.
is not in this category, and it unnecessarily repeats the xxreg1 part.
Something like
Syntax error at `xxreg1' expecting a 32-bit register.
would be better.
This patch seems to add unnecessary restrictions. Why restrict the
source fields to registers, for example? It's also a bit of an
unnecessary restriction to force the entire ct_mark or ct_label field to
be set.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
