Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Yi-Hung Wei <[email protected]> needs to sign off. WARNING: Line is 80 characters long (recommended limit is 79) #177 FILE: Documentation/intro/install/afxdp.rst:98: - The following optional Kconfig options are also recommended, but not required: WARNING: Line is 83 characters long (recommended limit is 79) #185 FILE: Documentation/intro/install/afxdp.rst:106: - If possible, run **./xdpsock -r -N -z -i <your device>** under linux/samples/bpf. WARNING: Line is 81 characters long (recommended limit is 79) #186 FILE: Documentation/intro/install/afxdp.rst:107: This is the OVS indepedent benchmark tools for AF_XDP. It makes sure your basic WARNING: Line is 84 characters long (recommended limit is 79) #197 FILE: Documentation/intro/install/afxdp.rst:118: Second, go into the Linux source directory and build libbpf in the tools directory:: WARNING: Line is 95 characters long (recommended limit is 79) #212 FILE: Documentation/intro/install/afxdp.rst:133: Third, ensure the standard OVS requirements are installed and bootstrap/configure the package:: WARNING: Line is 81 characters long (recommended limit is 79) #226 FILE: Documentation/intro/install/afxdp.rst:147: cat tests/system-afxdp-testsuite.dir/<failed number>/system-afxdp-testsuite.log WARNING: Line is 82 characters long (recommended limit is 79) #231 FILE: Documentation/intro/install/afxdp.rst:152: Before running OVS with AF_XDP, make sure the libbpf and libelf are set-up right:: WARNING: Line is 88 characters long (recommended limit is 79) #235 FILE: Documentation/intro/install/afxdp.rst:156: Open vSwitch should be started using userspace datapath as described in :doc:`general`:: WARNING: Line is 87 characters long (recommended limit is 79) #259 FILE: Documentation/intro/install/afxdp.rst:180: options:n_rxq=4 options:xdpmode=drv other_config:pmd-rxq-affinity="0:1,1:2,2:3,3:4" WARNING: Line is 87 characters long (recommended limit is 79) #311 FILE: Documentation/intro/install/afxdp.rst:232: While running the traffic, use linux perf tool to see where your cpu spends its cycle:: WARNING: Line is 96 characters long (recommended limit is 79) #329 FILE: Documentation/intro/install/afxdp.rst:250: ovs-vswitchd --no-chdir --pidfile -vvconn -vofproto_dpif -vunixctl --disable-system --detach WARNING: Line is 85 characters long (recommended limit is 79) #331 FILE: Documentation/intro/install/afxdp.rst:252: protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13,OpenFlow14,OpenFlow15 \ WARNING: Line is 81 characters long (recommended limit is 79) #688 FILE: lib/netdev-afxdp.c:95: (struct dp_packet_afxdp *)((char *)base + i * sizeof(struct dp_packet_afxdp)) WARNING: Line is 81 characters long (recommended limit is 79) #691 FILE: lib/netdev-afxdp.c:98: static uint32_t opt_xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST | XDP_FLAGS_SKB_MODE; WARNING: Line is 81 characters long (recommended limit is 79) #694 FILE: lib/netdev-afxdp.c:101: static uint32_t opt_xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST | XDP_FLAGS_DRV_MODE; WARNING: Empty return followed by brace, consider omitting #867 FILE: lib/netdev-afxdp.c:274: } WARNING: Empty return followed by brace, consider omitting #881 FILE: lib/netdev-afxdp.c:288: } WARNING: Empty return followed by brace, consider omitting #961 FILE: lib/netdev-afxdp.c:368: } WARNING: Empty return followed by brace, consider omitting #1149 FILE: lib/netdev-afxdp.c:556: } Lines checked: 3063, Warnings: 19, Errors: 1 build: make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath' make[2]: Entering directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' depbase=`echo lib/aes128.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/aes128.lo -MD -MP -MF $depbase.Tpo -c -o lib/aes128.lo lib/aes128.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/aes128.lo -MD -MP -MF lib/.deps/aes128.Tpo -c lib/aes128.c -o lib/aes128.o depbase=`echo lib/backtrace.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/backtrace.lo -MD -MP -MF $depbase.Tpo -c -o lib/backtrace.lo lib/backtrace.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/backtrace.lo -MD -MP -MF lib/.deps/backtrace.Tpo -c lib/backtrace.c -o lib/backtrace.o depbase=`echo lib/bfd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/bfd.lo -MD -MP -MF $depbase.Tpo -c -o lib/bfd.lo lib/bfd.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/bfd.lo -MD -MP -MF lib/.deps/bfd.Tpo -c lib/bfd.c -o lib/bfd.o In file included from lib/dp-packet.h:33:0, from lib/bfd.c:28: ./lib/xdpsock.h:21:23: fatal error: linux/bpf.h: No such file or directory #include <linux/bpf.h> ^ compilation terminated. make[2]: *** [lib/bfd.lo] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' make: *** [all] Error 2 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
