On Wed, Apr 24, 2019 at 03:40:21PM +0300, Ilya Maximets wrote: > On 24.04.2019 2:42, Ben Pfaff wrote: > > cgcc, the "sparse" wrapper that OVS uses, can be told the host architecture > > or the host OS or both. Until now, OVS has told it the host architecture > > because it is fairly common that it doesn't guess it automatically. Until > > now, OS has not told it the host OS, assuming that it would get it right. > > However, it doesn't--if you tell it the host OS or the host architecture, > > it doesn't really have a default for the other. This means that on Linux > > (presumably the only OS where sparse works properly for OVS), it was not > > defining __linux__, which caused some weird behavior. > > > > This commit adds a flag to the cgcc invocation to make it define __linux__ > > on Linux, and it fixes some errors that this would otherwise cause. > > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > LGTM, > Acked-by: Ilya Maximets <[email protected]> > > One minor comment inline.
Thanks, I fixed that and applied this to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
