On Thu, May 02, 2019 at 09:34:05PM -0700, Darrell Ball wrote: > For performance and code simplification reasons, add rcu support for > conntrack. The array of hmaps is replaced by a cmap as part of this > conversion. Using a single map also simplifies the handling of NAT > and allows the removal of the nat_conn map and friends. Per connection > entry locks are introduced, which are needed in a few code paths. > > Signed-off-by: Darrell Ball <[email protected]>
In struct conn, what does the lock member protect? I recommend noting that in the struct definition. It would aid code review. Perhaps they should be marked as OVS_GUARDED. I think that 'conn_type' and 'exp_list_id' contain enumerated values, so it would be best to declare them as those types, because it makes code clearer and sometimes enables the compiler to give better diagnostics. Maybe you are concerned about the sizes of those types? You can use OVS_PACKED_ENUM to keep them small. I'd like to take another look once the locking is clearer to me. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
