> -----Original Message-----
> From: Ilya Maximets [mailto:[email protected]]
> Sent: Wednesday, May 8, 2019 3:20 PM
> To: Van Haaren, Harry <[email protected]>; [email protected]
> Cc: Stokes, Ian <[email protected]>; [email protected];
> [email protected]
> Subject: Re: [PATCH v8 4/5] dpif-netdev: refactor generic implementation

<snip>

> >  static void
> > @@ -7556,6 +7567,7 @@ dpcls_destroy_subtable(struct dpcls *cls, struct
> dpcls_subtable *subtable)
> >      cmap_remove(&cls->subtables_map, &subtable->cmap_node,
> >                  subtable->mask.hash);
> >      cmap_destroy(&subtable->rules);
> > +    ovsrcu_postpone(free, subtable->mf_masks);
> >      ovsrcu_postpone(free, subtable);
> >  }
> 
> 
> This is not current master. You need to rebase.
> Please, pay attention to recent subtables related commit:
> 0fcf0776c72a ("Double postponing to free subtables.")

Correct - thanks for the pointer. Indeed during the rebase I've added the 
actual free of the mf_masks as a double-postponed call too.


> Best regards, Ilya Maximets.

I'll post v9 very shortly, which includes the count_1bits() feedback as per 
other email.

Thanks for feedback, -H
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to