On Wed, May 08, 2019 at 02:59:32PM +0200, Lorenzo Bianconi wrote:
> > On Tue, May 07, 2019 at 03:08:52PM +0200, Lorenzo Bianconi wrote:
> > > Use sb mac binding table to trigger ip buffer dequeueing instead of
> > > the APR/ND packet reception since the ARP reply can be managed on a
> > > different chassis if a gw router port is scheduled on a different
> > > node
> > > 
> > > Signed-off-by: Lorenzo Bianconi <[email protected]>
> > 
> > Thanks!
> > 
> > buffered_mac_bindings doesn't seem to really be used as a hash table:
> > nothing ever searches it.  Should it be a linked list?  Or maybe it's
> > just an hmap because destroy_buffered_packets() expects that.  Not a big
> > deal, just a surprise.
> 
> Hi Ben,
> 
> Thx for the fast review :)
> Yes, you right. I just maintained the same code architecture. I will post a
> patch to convert buffered_mac_bindings to a linked list

OK.  I'll take a look.  Maybe it does not actually make the code better;
I'll see.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to