On Tue, May 07, 2019 at 10:34:37PM +0000, Ankur Sharma wrote:
> Background:
> [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
> [2]
> https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This series seems very reasonable to me.
I could quibble with the enumerated naming choices. For example,
"always" and "never" plus "if-needed" or "if-nonzero" seem like good
names too. But there is not really anything wrong with the current
choices either.
Patch 2 should add an item to NEWS.
This bit of documentation could be improved: I guess it really means
"retain the 802.1Q header" in such frames, not "keep":
For <code>include-non-zero</code> Open vSwitch omits the
802.1Q header on output if both the VLAN ID and priority would
be zero. Set to <code>include</code> to keep such frames as
well.
I'm happy with it otherwise. Thank you! I'll look forward to v7.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
