On 13.05.2019 18:56, Ophir Munk wrote: > > >> -----Original Message----- >> From: Ilya Maximets <[email protected]> >> Sent: Monday, May 13, 2019 5:02 PM >> To: [email protected] >> Cc: Ian Stokes <[email protected]>; Flavio Leitner <[email protected]>; >> Ophir Munk <[email protected]>; Kevin Traynor >> <[email protected]>; Roni Bar Yanai <[email protected]>; Ilya >> Maximets <[email protected]> >> Subject: [PATCH 2/2] dpif-netdev: Forbid vport offloading attempts. >> >> 'netdev_flow_put()' for vports could eventually succeed for userspace >> datapath in case there is a kernel datapath with similar vport at the same >> time. The root cause is that vports like 'vxlan' uses same 'vxlan_sys_<port>' >> system interfaces for flow offloading and there is no way to distinguish >> system and userspace vports using only 'netdev' structure. >> >> Let's forbid vport offloading from userspace datapath to avoid installing >> userspace flows to unrelated system devices. >> >> Future dynamic flow API management will allow to enable vport offloading >> back using more flexible checks. >> >> Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id") > > The "Fixes ..." is not relevant to this patch.
Why not? The patch is not directly applicable on top of 241bad15d99a, however the bad code was introduced in this patch. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
