On 15.05.2019 19:13, Ilya Maximets wrote:
> Hi Aaron.
>
> Robot complains about lines not touched by this patch.
> This is strange.
I suspect that it's because of file renaming.
What git version you're using? Or maybe some special options?
>
> Best regards, Ilya Maximets.
>
> On 15.05.2019 19:05, 0-day Robot wrote:
>> Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> checkpatch:
>> ERROR: Improper whitespace around control block
>> #1065 FILE: lib/netdev-offload-tc.c:173:
>> HMAP_FOR_EACH_WITH_HASH(data, ufid_node, ufid_hash, &ufid_tc) {
>>
>> ERROR: Improper whitespace around control block
>> #1135 FILE: lib/netdev-offload-tc.c:243:
>> HMAP_FOR_EACH_WITH_HASH(data, ufid_node, ufid_hash, &ufid_tc) {
>>
>> ERROR: Improper whitespace around control block
>> #1165 FILE: lib/netdev-offload-tc.c:273:
>> HMAP_FOR_EACH_WITH_HASH(data, tc_node, tc_hash, &ufid_tc) {
>>
>> ERROR: Improper whitespace around control block
>> #1209 FILE: lib/netdev-offload-tc.c:317:
>> HMAP_FOR_EACH_WITH_HASH(data, node, hash, &prios) {
>>
>> WARNING: Line is 80 characters long (recommended limit is 79)
>> #1471 FILE: lib/netdev-offload-tc.c:579:
>> match_set_nw_src_masked(match, key->ipv4.ipv4_src,
>> mask->ipv4.ipv4_src);
>>
>> WARNING: Line is 80 characters long (recommended limit is 79)
>> #1472 FILE: lib/netdev-offload-tc.c:580:
>> match_set_nw_dst_masked(match, key->ipv4.ipv4_dst,
>> mask->ipv4.ipv4_dst);
>>
>> WARNING: Line is 82 characters long (recommended limit is 79)
>> #1545 FILE: lib/netdev-offload-tc.c:653:
>> size_t set_offset = nl_msg_start_nested(buf,
>> OVS_ACTION_ATTR_SET);
>>
>> WARNING: Line is 83 characters long (recommended limit is 79)
>> #1550 FILE: lib/netdev-offload-tc.c:658:
>> nl_msg_put_be64(buf, OVS_TUNNEL_KEY_ATTR_ID,
>> action->encap.id);
>>
>> WARNING: Line is 81 characters long (recommended limit is 79)
>> #1600 FILE: lib/netdev-offload-tc.c:708:
>> nl_msg_put_u32(buf, OVS_ACTION_ATTR_OUTPUT,
>> odp_to_u32(outport));
>>
>> WARNING: Line is 84 characters long (recommended limit is 79)
>> #1618 FILE: lib/netdev-offload-tc.c:726:
>> || (flower->offloaded_state ==
>> TC_OFFLOADED_STATE_UNDEFINED);
>>
>> ERROR: Improper whitespace around control block
>> #1756 FILE: lib/netdev-offload-tc.c:864:
>> NL_ATTR_FOR_EACH_UNSAFE(tun_attr, tun_left, tunnel, tunnel_len) {
>>
>> WARNING: Line is 85 characters long (recommended limit is 79)
>> #2026 FILE: lib/netdev-offload-tc.c:1134:
>> flower.mask.tunnel.id = (tnl->flags & FLOW_TNL_F_KEY) ?
>> tnl_mask->tun_id : 0;
>>
>> ERROR: Improper whitespace around control block
>> #2189 FILE: lib/netdev-offload-tc.c:1297:
>> NL_ATTR_FOR_EACH(nla, left, actions, actions_len) {
>>
>> WARNING: Line is 81 characters long (recommended limit is 79)
>> #2191 FILE: lib/netdev-offload-tc.c:1299:
>> VLOG_DBG_RL(&rl, "Can only support %d actions",
>> flower.action_count);
>>
>> WARNING: Line is 80 characters long (recommended limit is 79)
>> #2311 FILE: lib/netdev-offload-tc.c:1419:
>> VLOG_ERR_RL(&error_rl, "flow get failed (dev %s prio %d handle %d):
>> %s",
>>
>> Lines checked: 4898, Warnings: 9, Errors: 6
>>
>>
>> Please check this out. If you feel there has been an error, please email
>> [email protected]
>>
>> Thanks,
>> 0-day Robot
>>
>>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
