On Sun, May 26, 2019 at 12:59 PM Numan Siddique <[email protected]> wrote:
> > > On Sat, May 25, 2019 at 2:29 AM Ben Pfaff <[email protected]> wrote: > >> This commit adds new columns virtual_ip and virtual_parents in the >> Logical_Switch_Port table, which are used for the new 'virtual' port >> type. Most of the time, if a particular port type has type-specific >> options, they go in the "options" column. This has the advantage that >> we don't end up with lots of columns that are rarely used. It does have >> some disadvantages. For example, "options" can't be strong or weak >> references, and it requires some convention for having more than one >> value. virtual_ip and virtual_parents don't have the former issue, >> though virtual_parents does have the latter issue. Did you think >> through whether these should be options or new columns? >> > > Actually I didn't think through this. Thanks for pointing this out. I > think it > makes sense to have these as options. It would require a little bit of > parsing for virtual_parents - it has to be a comma separated string of > logical port names. I think that's reasonable as a logical > switch most likely will not have many ports of this new type. > > I will work on it and submit v2. > Done. v3 submitted - https://patchwork.ozlabs.org/patch/1105665/ Numan > Thanks > Numan > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
