On Wed, Jun 19, 2019 at 1:22 PM Ilya Maximets <i.maxim...@samsung.com> wrote:
> On 19.06.2019 10:26, David Marchand wrote: > > Rework the build script so that we can pass branches and tags. > > > > With this, DPDK_VER can be passed as: > > - a string starting with refs/ which is understood as a git reference. > > This triggers a git clone on DPDK_GIT (default value points to > > https://dpdk.org/git/dpdk) for a single branch pointing to this > > reference (to save some disk), > > - else, any other string which is understood as an official release. > > This triggers a tarball download on dpdk.org. > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > Changelog since v1: > > - removed (now unneeded) directory renames > > - added a "git log" so that we have the current git revision in the logs > > > > --- > > > Thanks! > > I tested this patch with: > > - DPDK=1 DPDK_GIT="https://dpdk.org/git/dpdk-stable"; > DPDK_VER="refs/heads/18.11" > > and > > - DPDK=1 DPDK_VER="refs/heads/master" > > Works fine. > Thanks Ilya. I could have detailed my non-reg tests: - DPDK=1 - DPDK=1 DPDK_VER=18.11.2 - DPDK=1 DPDK_VER=refs/tags/v18.11.2 DPDK_GIT= http://dpdk.org/git/dpdk-stable - DPDK=1 DPDK_VER=refs/heads/18.11 DPDK_GIT=http://dpdk.org/git/dpdk-stable > So, I pushed this and the previous patch to master. > Cool, so I suppose you will handle the changes on dpdk-latest, right? -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
