On 6/20/2019 9:19 PM, William Tu wrote: >> I'll be working on clarifying the documentation. And we need to clarify >> that we will not be supporting ip6gre because it >> requires ARPHRD_IP6GRE. OVS only works with ARPHRD_ETHER so it can only >> support ip6gretap. >> >>> Alternatively, we can maybe detect the options:remote_ip to be an >>> IPv4/IPv6 address in type=gre and do the proper adjustments behind the >>> scenes. >>> >>> What do you think? > But when users set type=gre, and underneath we might created gre or ip6gretap. > I think it better makes it clear using ip6gretap or gre.
In gre we use "gre" for both "gre" or "gretap", so we should maybe use "ip6gre" and not "ip6gretap", though "ip6gre" is not supported but only "ip6gretap". BTW, can't OVS be updated to support it as well in the future? In any case, I think documentation should be updated in the same commit. >> >> >> Would take user space changes. I'd be fine with it - I think it would >> work more like geneve and vxlan that way. >> > For geneve and vxlan (see drivers/net/geneve.c), it uses only one type > rtnl_link_ops.kind ="geneve" for handling both ipv6 and ipv4. > > But for gre/erspan, there are separate rtnl_link_ops.kind in > net/ipv4/ip_gre.c and net/ipv6/ip6_gre.c > So I think we have to do separate type=ip6gre or type=gre. > > Regards, > William > > >> - Greg _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
