On 24.06.2019 22:13, Ian Stokes wrote:
> On 5/23/2019 3:23 PM, David Marchand wrote:
>> Looking at the reload flag only every 1024 loops can be a long time
>> under load, since we might be handling 32 packets per polled rxq, per
>> iteration, which means up to poll_cnt * 32 * 1024 packets.
>> Look at the flag every loop, no major performance impact seen.
>>
>> Signed-off-by: David Marchand <david.march...@redhat.com>
>> Acked-by: Eelco Chaudron <echau...@redhat.com>
> 
> Looks/tested ok for me. Acked.
> 
> I've tested various setups in the series (adding/removining varios PMD 
> configurations, isolating and distributing queueus, queue re-balancing). I 
> also ran a number of scaling performance tests and did not see any impact on 
> the performance side.
> 
> As I said in the previous patches, I'll wait until Ilya has time to test also 
> as it's important that we don't see any regressions with this part of the 
> codebase for the various usecases.

Thanks, Ian, for review and testing. I'm looking at the patches
now and will reply today or tomorrow.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to