On Tue, Jun 25, 2019 at 01:12:11PM +0300, Ilya Maximets wrote: > 'netdev' datapath is implemented within ovs-vswitchd process and can > not exist without it, so it should be gracefully terminated with a > full cleanup of resources upon ovs-vswitchd exit. > > This change forces dpif cleanup for 'netdev' datapath regardless of > passing '--cleanup' to 'ovs-appctl exit'. Such solution allowes to > not pass this additional option everytime for userspace datapath > installations and also allowes to not terminate system datapath in > setups where both datapaths runs at the same time. > > Exception made for 'internal' ports that could have user ip/route > configuration. These ports will not be removed without '--cleanup'. > > This change fixes OVS disappearing from the DPDK point of view > (keeping HW NICs improperly configured, sudden closing of vhost-user > connections) and will help with linux devices clearing with upcoming > AF_XDP netdev support. > > Signed-off-by: Ilya Maximets <[email protected]>
I'm having trouble figuring out what the critical step is in the destruction process that this enables or disables. It controls whether dpif_port_del() gets called. There's a lot of stuff under dpif_port_del(), most of it indirect. I'm not sure which bit is the important one. Would you mind explaining what it is as part of the commit message? Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
