On Sat, Jul 6, 2019 at 3:00 AM Ben Pfaff <[email protected]> wrote: > On Mon, Jun 17, 2019 at 11:10:04AM +0530, [email protected] wrote: > > From: Numan Siddique <[email protected]> > > > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > > > Usage: ovs-appctl -t ovn-northd pause/resume/is-paused > > > > This feature will be useful if the CMS wants to > > - deploy OVN DB servers in active/passive mode and > > - run ovn-northd on all these nodes and use unix ctl sockets to > > connect to the local OVN DB servers. > > > > On the nodes where OVN Db ovsdb-servers are in passive mode, the local > ovn-northds > > will process the DB changes and calculate logical flows to be throw out > later > > because write txns are not allowed by these ovsdb-servers. It results in > > unncessary CPU usage. > > > > With these commands, CMS can pause ovn-northd on these node. A node > > which becomes master, can resume the ovn-northd. > > > > This feature will be useful in ovn-kubernetes if the above deployment > model > > is chosen. > > > > Signed-off-by: Numan Siddique <[email protected]> > > Thank you. This seems like a helpful feature. > > The commit message above explains the idea well at a high level, but the > documentation that it adds does not give the high level idea but only > the low level feature description. This could make it hard for a system > administrator to understand why the low level feature is there. I would > suggest sending a v2 that explains the high level idea in the > documentation as well as in the commit message. >
Thanks for the review. Sure I will do that and submit v2. Numan > > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
