Vasu Dasari <[email protected]> writes: > Aaron, > > I see that documentation for topics/testing is mostly one liners and precise. > And hence I chose one liner as well. > If I have to put all your recommended test, I think it is better to have a > subsection, "Debugging unit tests". > What do you think?
It's a good idea. > Ben, > > Will do. Also, note that I am using at_verbose variable if we are in verbose > mode or not. If user has not run the > test suite in verbose mode, none of the instructions to set the OVS_RUNDIR > variable, etc will appear on screen, > and hence user will not have a clue why script is pausing. So, I am also > qualifying the check for at_verbose > variable. I hope it is ok to use the at_verbose variable. > > -Vasu > > Vasu Dasari > > On Mon, Jul 15, 2019 at 3:59 PM Ben Pfaff <[email protected]> wrote: > > On Mon, Jul 15, 2019 at 03:22:42PM -0400, Vasu Dasari wrote: > > Origins for this patch are captured at > > https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048923.html. > > ... > > Aaron provided helpful comments. In addition: > > > +ovs_pause() { > > + $as_echo > "=====================================================" > > + $as_echo "Set following environment variable to use various ovs > utilities" > > + $as_echo "export OVS_RUNDIR=$ovs_base" > > + $as_echo "Press ENTER to continue: " > > + read > > +} > > The above uses $as_echo, which is what the AS_ECHO([...]) macro expands > into. It is better to use AS_ECHO itself, since in theory the > implementation could change in a later version of Autoconf. > > Thanks, > > Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
