LGTM Acked-by: Mark Michelson <[email protected]>
On 7/25/19 11:38 AM, Daniel Alvarez wrote:
Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd will crash (SIGSEV) because the current code injects a flow to emit the ICMP need-to-frag from its IPv4 address which does not exist. This patch is adding a check to skip the flow installation in case the port does not have any IPv4 address. Signed-off-by: Daniel Alvarez <[email protected]> --- ovn/northd/ovn-northd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index eb6c47cad..3542ba72f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -7705,7 +7705,8 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports, for (size_t i = 0; i < od->nbr->n_ports; i++) { struct ovn_port *rp = ovn_port_find(ports, od->nbr->ports[i]->name); - if (!rp || rp == od->l3dgw_port) { + if (!rp || rp == od->l3dgw_port || + !rp->lrp_networks.ipv4_addrs) { continue; } ds_clear(&match);
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
