On Mon, Aug 19, 2019 at 11:13 AM <nusid...@redhat.com> wrote: > > From: Numan Siddique <nusid...@redhat.com> > > This patch series adds support for building OVN from external OVS > sources. > > The first patch adds the support to compile OVN from external OVS sources. > The following configuration options are added when configuring OVN > * --with-ovs-source (mandatory) > * --with-ovs-build (optional) > > Patch 2 adds support to run OVN services using separate > directores > - Default run time dir - /usr/local/var/run/ovm > - Default log dir - /usr/loca/var/log/ovn > - Default db dir - /usr/loca/etc/ovn > > Patch 3 fixes "make rpm-fedora" which is presently broken > > Patch 4 runs OVN services as openvswitch user for rhel when rpms are > used. > > Patch 5 removes the python subdirectory as that directory belongs > to OVS and uses the required files from the OVS repo. > > v1 -> v2 > ======== > * Addressed the review comments. > * Swapped the patch 1 and 2 as it was easier to address Mark's comment > on OVS_RUNDIR/OVN_RUNDIR > * In patch 2, renamed m4/openvswitch.m4 to m4/ovn.m4 and renamed few of > the macros to OVS_* to OVN_*. > > Combined the patch 1 and 2 in this series which were submitted > separately earlier. > >
Hi Numan, Thanks for this work. I tried applying this series on master, and then removed the "ovs" subfolder just to see if it uses the external OVS completely. However I encountered some error: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I /home/hzhou/src/ovs/include -I /home/hzhou/src/ovs/_build/include -I /home/hzhou/src/ovs/lib -I /home/hzhou/src/ovs/_build/lib -I /home/hzhou/src/ovs -I /home/hzhou/src/ovs/_build -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -g -O2 -MT lib/logical-fields.lo -MD -MP -MF $depbase.Tpo -c -o lib/logical-fields.lo lib/logical-fields.c &&\ mv -f $depbase.Tpo $depbase.Plo lib/actions.c: In function 'encode_CHECK_PKT_LARGER': lib/actions.c:2592:9: warning: implicit declaration of function 'ofpact_put_CHECK_PKT_LARGER' [-Wimplicit-function-declaration] ofpact_put_CHECK_PKT_LARGER(ofpacts); ^ lib/actions.c:2592:9: warning: initialization makes pointer from integer without a cast lib/actions.c:2593:21: error: dereferencing pointer to incomplete type check_pkt_larger->pkt_len = cipl->pkt_len; ^ lib/actions.c:2594:21: error: dereferencing pointer to incomplete type check_pkt_larger->dst = expr_resolve_field(&cipl->dst); ^ Is this expected? Thanks, Han _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev