When a packet is received, the RSS hash is calculated if it is not already available. The Exact Match Cache (EMC) entry is then looked up using this RSS hash.
When a MPLS encapsulated packet is received, the MPLS header is popped and the packet is recirculated. Since the RSS hash has not been invalidated here, the EMC lookup for all decapsulated packets will hit the same entry even though these packets will have different tuple values. This degrades performance severely as different inner packets from the same MPLS tunnel would hit the same EMC entry. This patch invalidates RSS hash (by resetting offload flags) after MPLS header is popped. Signed-off-by: Nitin Katiyar <[email protected]> --- lib/packets.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/packets.c b/lib/packets.c index ab0b1a3..12053df 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -411,6 +411,10 @@ pop_mpls(struct dp_packet *packet, ovs_be16 ethtype) /* Shift the l2 header forward. */ memmove((char*)dp_packet_data(packet) + MPLS_HLEN, dp_packet_data(packet), len); dp_packet_resize_l2_5(packet, -MPLS_HLEN); + + /* Invalidate offload flags as they are not valid after + * decapsulation of MPLS header. */ + dp_packet_reset_offload(packet); } } -- 1.9.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
