On Mon, Sep 02, 2019 at 04:36:47PM +0800, Yanqin Wei wrote: > The padding length is (packet size - ipv6 header length - ipv6 plen). This > patch fixes incorrect padding size checking in ipv6_sanity_check. > > Reviewed-by: Gavin Hu <[email protected]> > Signed-off-by: Yanqin Wei <[email protected]>
Looks good to me. Acked-by: William Tu <[email protected]> > --- > lib/flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/flow.c b/lib/flow.c > index ac6a4e1..0413c67 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -699,7 +699,7 @@ ipv6_sanity_check(const struct ovs_16aligned_ip6_hdr *nh, > size_t size) > return false; > } > /* Jumbo Payload option not supported yet. */ > - if (OVS_UNLIKELY(size - plen > UINT8_MAX)) { > + if (OVS_UNLIKELY(size - (plen + IPV6_HEADER_LEN) > UINT8_MAX)) { > return false; > } > > -- > 2.7.4 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
