On Wed, Sep 25, 2019 at 9:51 PM Ben Pfaff <b...@ovn.org> wrote: > On Wed, Sep 25, 2019 at 02:53:53PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique <nusid...@redhat.com> > > > > We can delete the ovs subtree as OVN doesn't depend on this folder any > more > > for compilation. > > > > ovs subtree is deleted as "git rm -rf ovs" > > > > Please note that I am only sending the cover letter of this patch to the > > ML as the patch is 25M big. > > > > The actual patch can be found here - > > > https://github.com/numansiddique/ovn/commit/7e6af9d8c3da212fb8368055006aa3fa5d0f3cfd > > https://github.com/numansiddique/ovn/tree/delete_ovs_subtree > > Thanks a lot! > > I got an odd error message running "make check". I tracked it down and > I think you should fold in the following incremental. > > With that addendum: > Acked-by: Ben Pfaff <b...@ovn.org> >
Thanks for the review and fixing the annoying message. With your suggested changes I applied this patch to master. Numan > > diff --git a/tests/atlocal.in b/tests/atlocal.in > index 2e565d788b15..842f5ad62393 100644 > --- a/tests/atlocal.in > +++ b/tests/atlocal.in > @@ -62,8 +62,8 @@ Linux) > # thread-safe. See > https://bugzilla.redhat.com/show_bug.cgi?id=585674 and > # in particular the patch attached there, which was applied to glibc > CVS as > # "Restore locking in free_check." between 1.11 and 1.11.1. > - vswitchd=$abs_top_builddir/vswitchd/ovs-vswitchd > - glibc=`ldd $vswitchd | sed -n 's/^ libc\.[^ ]* => \([^ ]*\) .*/\1/p'` > + binary=$abs_top_builddir/controller/ovn-controller > + glibc=`ldd $binary | sed -n 's/^ libc\.[^ ]* => \([^ ]*\) .*/\1/p'` > glibc_version=`$glibc | sed -n '1s/.*version > \([0-9]\{1,\}\.[0-9]\{1,\}\).*/\1/p'` > case $glibc_version in > 2.[0-9] | 2.1[01]) mcheck=disabled ;; > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
