On Wed, Oct 09, 2019 at 02:50:39PM +0800, wenxu wrote: > > On 10/9/2019 1:33 AM, Ben Pfaff wrote: > > On Tue, Oct 08, 2019 at 03:01:44PM +0800, wenxu wrote: > >> Thx. I found the root cause of the bad performance delete tc flower > >> rule in revalidator threads. > >> > >> All the block is for the netdev_hmap_mutex mutex. In the > >> netdev_ports_get the handler with compete with revlalidator. The > >> netdev_ifindex_to_odp_port and netdev_ports_flow_del with this mutex > >> will bolock revalidator each other. So Maybe replace the hmap to > >> rcuhlist is much better? But there is no such rcuhlist utilitis in > >> the lib > > The cmap data structure might be better suited for this kind of use. > > Would it solve the problem, in your view? > > yes cmap can this. But I find it is more easy to solve the problem through > replacing > > the netdev_hmap_mutex to netdev_hmap_rwlock.
OK. That seems reasonable too. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
