On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > On Wed, Oct 09, 2019 at 04:56:40PM -0700, [email protected] wrote: > > From: Aliasgar Ginwala <[email protected]> > > > > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for > > ovn-nbctl and ovn-sbctl respectively where user can set any single > > supported option. e.g export OVN_NBCTL_OPTIONS=--no-leader-only. > > Above env var OVN_NBCTL_OPTIONS have no effect if user runs > > command as ovn-nbctl --no-leader-only <command> > > > > Signed-off-by: Aliasgar Ginwala <[email protected]> > > I think that this could be factored out into lib/command-line.c rather > than done as a copy-and-paste into two files. > > I don't think that the ops_passed variable needs to be static.
Also, I'd consider giving an example in the documentation of how to use this new variable. The purpose is unclear enough that I might not be able to quickly guess how or why to use it without an example. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
