Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#349 FILE: ovn-inb.xml:35:
Northbound configuration for OVN interconnection. This table must have
exactly
WARNING: Line is 80 characters long (recommended limit is 79)
#381 FILE: ovn-inb.xml:67:
Each row represents one transit logical switch for interconnection between
WARNING: Line is 82 characters long (recommended limit is 79)
#473 FILE: ovn-inb.xml:159:
<dt><code>ssl:<var>host</var></code>[<code>:<var>port</var></code>]</dt>
WARNING: Line is 81 characters long (recommended limit is 79)
#480 FILE: ovn-inb.xml:166:
specified via command-line options or the <ref table="SSL"/>
table.
WARNING: Line is 82 characters long (recommended limit is 79)
#491 FILE: ovn-inb.xml:177:
<dt><code>tcp:<var>host</var></code>[<code>:<var>port</var></code>]</dt>
WARNING: Line is 84 characters long (recommended limit is 79)
#497 FILE: ovn-inb.xml:183:
address, wrap it in square brackets, e.g.
<code>tcp:[::1]:6640</code>.
WARNING: Line is 85 characters long (recommended limit is 79)
#503 FILE: ovn-inb.xml:189:
<dt><code>pssl:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>
WARNING: Line is 80 characters long (recommended limit is 79)
#515 FILE: ovn-inb.xml:201:
A valid SSL configuration must be provided when this form is used,
WARNING: Line is 85 characters long (recommended limit is 79)
#527 FILE: ovn-inb.xml:213:
<dt><code>ptcp:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>
WARNING: Line is 110 characters long (recommended limit is 79)
#602 FILE: ovn-inb.xml:288:
type='{"type": "string", "enum": ["set", ["VOID", "BACKOFF",
"CONNECTING", "ACTIVE", "IDLE"]]}'>
WARNING: Line is 94 characters long (recommended limit is 79)
#851 FILE: utilities/ovn-inbctl.8.xml:4:
<p>ovn-inbctl -- Open Virtual Network interconnection northbound db
management utility</p>
WARNING: Line is 94 characters long (recommended limit is 79)
#854 FILE: utilities/ovn-inbctl.8.xml:7:
<p><code>ovn-inbctl</code> [<var>options</var>] <var>command</var>
[<var>arg</var>...]</p>
WARNING: Line is 90 characters long (recommended limit is 79)
#857 FILE: utilities/ovn-inbctl.8.xml:10:
<p>This utility can be used to manage the OVN interconnection northbound
database.</p>
WARNING: Line is 81 characters long (recommended limit is 79)
#903 FILE: utilities/ovn-inbctl.8.xml:56:
<p>These commands query and modify the contents of <code>ovsdb</code>
tables.
WARNING: Line is 90 characters long (recommended limit is 79)
#905 FILE: utilities/ovn-inbctl.8.xml:58:
as such they operate at a lower level than other <code>ovn-inbctl</code>
commands.</p>
WARNING: Line is 82 characters long (recommended limit is 79)
#907 FILE: utilities/ovn-inbctl.8.xml:60:
<p>Each of these commands has a <var>table</var> parameter to identify a
table
WARNING: Line is 87 characters long (recommended limit is 79)
#931 FILE: utilities/ovn-inbctl.8.xml:84:
<xi:include href="lib/db-ctl-base.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 114 characters long (recommended limit is 79)
#945 FILE: utilities/ovn-inbctl.8.xml:98:
<dt>[<code>--inactivity-probe=</code><var>msecs</var>]
<code>set-connection</code> <var>target</var>...</dt>
WARNING: Line is 80 characters long (recommended limit is 79)
#948 FILE: utilities/ovn-inbctl.8.xml:101:
<code>--inactivity-probe=</code><var>msecs</var> to override the default
WARNING: Line is 83 characters long (recommended limit is 79)
#949 FILE: utilities/ovn-inbctl.8.xml:102:
idle connection inactivity probe time. Use 0 to disable inactivity
probes.
WARNING: Line is 83 characters long (recommended limit is 79)
#980 FILE: utilities/ovn-inbctl.8.xml:133:
Otherwise, the default is <code>unix:@RUNDIR@/ovninb_db.sock</code>, but
this
WARNING: Line is 80 characters long (recommended limit is 79)
#992 FILE: utilities/ovn-inbctl.8.xml:145:
<code>--no-leader-only</code>, <code>ovn-inbctl</code> will use any server
WARNING: Line is 80 characters long (recommended limit is 79)
#1002 FILE: utilities/ovn-inbctl.8.xml:155:
<xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 81 characters long (recommended limit is 79)
#1007 FILE: utilities/ovn-inbctl.8.xml:160:
<xi:include href="lib/table.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 89 characters long (recommended limit is 79)
#1015 FILE: utilities/ovn-inbctl.8.xml:168:
<xi:include href="lib/ssl-bootstrap.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 82 characters long (recommended limit is 79)
#1019 FILE: utilities/ovn-inbctl.8.xml:172:
<xi:include href="lib/common.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line lacks whitespace around operator
#1331 FILE: utilities/ovn-inbctl.c:304:
ts-add SWITCH create a transit switch named SWITCH\n\
WARNING: Line lacks whitespace around operator
#1332 FILE: utilities/ovn-inbctl.c:305:
ts-del SWITCH delete SWITCH\n\
WARNING: Line lacks whitespace around operator
#1333 FILE: utilities/ovn-inbctl.c:306:
ts-list print all transit switches\n\
WARNING: Line lacks whitespace around operator
#1336 FILE: utilities/ovn-inbctl.c:309:
get-connection print the connections\n\
WARNING: Line lacks whitespace around operator
#1337 FILE: utilities/ovn-inbctl.c:310:
del-connection delete the connections\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1338 FILE: utilities/ovn-inbctl.c:311:
[--inactivity-probe=MSECS]\n\
WARNING: Line lacks whitespace around operator
#1339 FILE: utilities/ovn-inbctl.c:312:
set-connection TARGET... set the list of connections to TARGET...\n\
WARNING: Line lacks whitespace around operator
#1342 FILE: utilities/ovn-inbctl.c:315:
get-ssl print the SSL configuration\n\
WARNING: Line lacks whitespace around operator
#1343 FILE: utilities/ovn-inbctl.c:316:
del-ssl delete the SSL configuration\n\
WARNING: Line lacks whitespace around operator
#1344 FILE: utilities/ovn-inbctl.c:317:
set-ssl PRIV-KEY CERT CA-CERT [SSL-PROTOS [SSL-CIPHERS]] \
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1351 FILE: utilities/ovn-inbctl.c:324:
--db=DATABASE connect to DATABASE\n\
WARNING: Line lacks whitespace around operator
#1353 FILE: utilities/ovn-inbctl.c:326:
--no-leader-only accept any cluster member, not just the leader\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1354 FILE: utilities/ovn-inbctl.c:327:
-t, --timeout=SECS wait at most SECS seconds\n\
WARNING: Line lacks whitespace around operator
#1355 FILE: utilities/ovn-inbctl.c:328:
--dry-run do not commit changes to database\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1362 FILE: utilities/ovn-inbctl.c:335:
--no-syslog equivalent to --verbose=inbctl:syslog:warn\n");
WARNING: Comment with 'xxx' marker
#1782 FILE: utilities/ovn-inbctl.c:755:
/* XXX add verification that table is empty */
Lines checked: 1981, Warnings: 48, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
