Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#54 FILE: utilities/ovn-ctl:112:
$DB_INB_SYNC_FROM_PORT $ovninb_active_conf_file
ovninb_db.ctl
WARNING: Line is 81 characters long (recommended limit is 79)
#59 FILE: utilities/ovn-ctl:117:
$DB_ISB_SYNC_FROM_PORT $ovnisb_active_conf_file
ovnisb_db.ctl
WARNING: Line is 91 characters long (recommended limit is 79)
#189 FILE: utilities/ovn-ctl:494:
OVS_RUNDIR=${OVS_RUNDIR} start_ovn_daemon "$OVN_IC_PRIORITY"
"$OVN_IC_WRAPPER" "$@"
WARNING: Line is 80 characters long (recommended limit is 79)
#393 FILE: utilities/ovn-ctl:838:
restart_ic_ovsdb restart ovn interconnection ovsdb-server processes
WARNING: Line is 83 characters long (recommended limit is 79)
#409 FILE: utilities/ovn-ctl:855:
promote_ovninb promote ovn ic-northbound db backup server to
active
WARNING: Line is 83 characters long (recommended limit is 79)
#410 FILE: utilities/ovn-ctl:856:
promote_ovnisb promote ovn ic-southbound db backup server to
active
WARNING: Line is 82 characters long (recommended limit is 79)
#411 FILE: utilities/ovn-ctl:857:
demote_ovninb demote ovn ic-northbound db active server to
backup
WARNING: Line is 82 characters long (recommended limit is 79)
#412 FILE: utilities/ovn-ctl:858:
demote_ovnisb demote ovn ic-southbound db active server to
backup
WARNING: Line is 83 characters long (recommended limit is 79)
#423 FILE: utilities/ovn-ctl:880:
--ovn-manage-ovsdb=yes|no Whether or not the OVN NB/SB databases
should be
WARNING: Line is 85 characters long (recommended limit is 79)
#436 FILE: utilities/ovn-ctl:896:
--ovn-ic-log=STRING ovn-ic process logging params (default:
$OVN_IC_LOG)
WARNING: Line is 83 characters long (recommended limit is 79)
#437 FILE: utilities/ovn-ctl:897:
--ovn-ic-logfile=STRING ovn-ic process log file (default:
$OVN_IC_LOGFILE)
WARNING: Line is 81 characters long (recommended limit is 79)
#457 FILE: utilities/ovn-ctl:964:
--db-inb-addr=ADDR OVN IC Northbound db ptcp address (default:
$DB_INB_ADDR)
WARNING: Line is 81 characters long (recommended limit is 79)
#459 FILE: utilities/ovn-ctl:966:
--db-isb-addr=ADDR OVN IC Southbound db ptcp address (default:
$DB_ISB_ADDR)
WARNING: Line is 104 characters long (recommended limit is 79)
#463 FILE: utilities/ovn-ctl:970:
--db-inb-sync-from-addr=ADDR OVN IC Northbound active db tcp address
(default: $DB_INB_SYNC_FROM_ADDR)
WARNING: Line is 101 characters long (recommended limit is 79)
#464 FILE: utilities/ovn-ctl:971:
--db-inb-sync-from-port=PORT OVN IC Northbound active db tcp port (default:
$DB_INB_SYNC_FROM_PORT)
WARNING: Line is 105 characters long (recommended limit is 79)
#465 FILE: utilities/ovn-ctl:972:
--db-inb-sync-from-proto=PROTO OVN IC Northbound active db transport
(default: $DB_INB_SYNC_FROM_PROTO)
WARNING: Line is 119 characters long (recommended limit is 79)
#466 FILE: utilities/ovn-ctl:973:
--db-inb-create-insecure-remote=yes|no Create ptcp OVN IC Northbound remote
(default: $DB_INB_CREATE_INSECURE_REMOTE)
WARNING: Line is 104 characters long (recommended limit is 79)
#467 FILE: utilities/ovn-ctl:974:
--db-isb-sync-from-addr=ADDR OVN IC Southbound active db tcp address
(default: $DB_ISB_SYNC_FROM_ADDR)
WARNING: Line is 101 characters long (recommended limit is 79)
#468 FILE: utilities/ovn-ctl:975:
--db-isb-sync-from-port=ADDR OVN IC Southbound active db tcp port (default:
$DB_ISB_SYNC_FROM_PORT)
WARNING: Line is 105 characters long (recommended limit is 79)
#469 FILE: utilities/ovn-ctl:976:
--db-isb-sync-from-proto=PROTO OVN IC Southbound active db transport
(default: $DB_ISB_SYNC_FROM_PROTO)
WARNING: Line is 119 characters long (recommended limit is 79)
#470 FILE: utilities/ovn-ctl:977:
--db-isb-create-insecure-remote=yes|no Create ptcp OVN IC Southbound remote
(default: $DB_ISB_CREATE_INSECURE_REMOTE)
WARNING: Line is 83 characters long (recommended limit is 79)
#475 FILE: utilities/ovn-ctl:982:
--db-inb-cluster-local-proto=PROTO OVN_IC_Northbound cluster local db
transport \
WARNING: Line is 83 characters long (recommended limit is 79)
#487 FILE: utilities/ovn-ctl:994:
--db-isb-cluster-local-proto=PROTO OVN_IC_Southbound cluster local db
transport \
WARNING: Line is 125 characters long (recommended limit is 79)
#497 FILE: utilities/ovn-ctl:1004:
--db-inb-use-remote-in-db=yes|no OVN_IC_Northbound db listen on target
connection table (default: $DB_INB_USE_REMOTE_IN_DB)
WARNING: Line is 125 characters long (recommended limit is 79)
#498 FILE: utilities/ovn-ctl:1005:
--db-isb-use-remote-in-db=yes|no OVN_IC_Southbound db listen on target
connection table (default: $DB_ISB_USE_REMOTE_IN_DB)
WARNING: Line is 80 characters long (recommended limit is 79)
#714 FILE: utilities/ovn-ctl.8.xml:145:
<p><code>--db-inb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p>
WARNING: Line is 80 characters long (recommended limit is 79)
#720 FILE: utilities/ovn-ctl.8.xml:151:
<p><code>--db-isb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p>
WARNING: Line is 81 characters long (recommended limit is 79)
#747 FILE: utilities/ovn-ctl.8.xml:197:
<p><code>--ovninb-db=tcp:x.x.x.x:6645
--ovnisb-db=tcp:x.x.x.x:6646</code></p>
Lines checked: 775, Warnings: 28, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
