Thanks Numan for taking care. I tested that on branch 2.11 ovs and hence didn't notice this warning. Sorry for the miss.
________________________________ From: Numan Siddique <[email protected]> Sent: Thursday, October 31, 2019 11:15 AM To: aginwala <[email protected]>; Ginwala, Aliasgar <[email protected]> Cc: ovs dev <[email protected]>; Ben Pfaff <[email protected]> Subject: Re: [ovs-dev] [PATCH v3 ovn] ovn-nb/sbctl.c: Use env variables for passing options. On Sat, Oct 26, 2019 at 2:02 AM Ben Pfaff <[email protected]> wrote: > > On Fri, Oct 25, 2019 at 01:10:57PM -0700, [email protected] wrote: > > From: Aliasgar Ginwala <[email protected]> > > > > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for > > ovn-nbctl and ovn-sbctl respectively where user can set > > supported ovn-nb/sbctl options using environment variable. > > e.g. OVN_SBCTL_OPTIONS="--db=unix:sb1.ovsdb --no-leader-only" > > > > Signed-off-by: Aliasgar Ginwala <[email protected]> > > I didn't test this. > > Acked-by: Ben Pfaff <[email protected]> Hi Aliasgar, Compilation was failing with the below errors **** utilities/ovn-sbctl.8:286: warning: macro `User' not defined utilities/ovn-sbctl.8:287: warning: macro `variable.' not defined utilities/ovn-sbctl.8:288: warning: macro `export' not defined (possibly missing space after `ex') utilities/ovn-sbctl.8:289: warning: macro `However' not defined utilities/ovn-sbctl.8:290: warning: macro `options' not defined utilities/ovn-sbctl.8:291: warning: macro `e.g.:' not defined **** I applied this patch to master with the below changes to fix the compilation errors. Thanks Numan ******************** diff --git a/utilities/ovn-sbctl.8.in b/utilities/ovn-sbctl.8.in index b3c21d625..644f94432 100644 --- a/utilities/ovn-sbctl.8.in +++ b/utilities/ovn-sbctl.8.in @@ -94,12 +94,12 @@ would normally happen only if the database cannot be contacted, or if the system is overloaded.) . .IP "\fBOVN_SBCTL_OPTIONS\fR" -.User can set one or more options using \fBOVN_SBCTL_OPTIONS\fR environment -.variable. Under the Bourne shell this might be done like this: -.export \fBOVN_SBCTL_OPTIONS\fR"="--db=unix:sb1.ovsdb --no-leader-only". -.However user can still over-ride environment options by passing different -.options in cli. When the environment variable is no longer needed, unset it, -.e.g.: unset \fBOVN_SBCTL_OPTIONS\fR" +User can set one or more options using \fBOVN_SBCTL_OPTIONS\fR environment +variable. Under the Bourne shell this might be done like this: +export \fBOVN_SBCTL_OPTIONS\fR"="--db=unix:sb1.ovsdb --no-leader-only". +However user can still over-ride environment options by passing different +options in cli. When the environment variable is no longer needed, unset it, +e.g.: unset \fBOVN_SBCTL_OPTIONS\fR" . .so lib/vlog.man .so lib/common.man ********** > _______________________________________________ > dev mailing list > [email protected] > https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Caginwala%40ebay.com%7C27505d851de340eba58508d75e2e4d91%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C637081425277298581&sdata=pWsRSpTF1C8%2BPp8r5UFuEzPLKKX1jzBD%2FKJrUPozIrY%3D&reserved=0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
