On Wed, Oct 30, 2019 at 02:40:35PM +0200, Roi Dayan wrote:
> From: Dmytro Linkin <[email protected]>
> 
> Tunnel id 0 is not printed unless tunnel flag FLOW_TNL_F_KEY is set.
> Fix that by always setting FLOW_TNL_F_KEY when tunnel id is valid.
> 
> Fixes: 0227bf092ee6 ("lib/tc: Support optional tunnel id")
> Signed-off-by: Dmytro Linkin <[email protected]>
> Reviewed-by: Roi Dayan <[email protected]>

Hi Roi,

this looks fine to me but I am holding off on pushing it
until master passes travis-ci again.

It also seems to backport cleanly to branch-2.11 and I plan
to apply it there too.

If it is suitable for older branches could you please post a
backport/backports?

Thanks

> ---
>  lib/netdev-offload-tc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
> index f6d1abb2e695..502e73ad5332 100644
> --- a/lib/netdev-offload-tc.c
> +++ b/lib/netdev-offload-tc.c
> @@ -600,6 +600,7 @@ parse_tc_flower_to_match(struct tc_flower *flower,
>      if (flower->tunnel) {
>          if (flower->mask.tunnel.id) {
>              match_set_tun_id(match, flower->key.tunnel.id);
> +            match->flow.tunnel.flags |= FLOW_TNL_F_KEY;
>          }
>          if (flower->key.tunnel.ipv4.ipv4_dst) {
>              match_set_tun_src(match, flower->key.tunnel.ipv4.ipv4_src);
> -- 
> 2.8.4
> 
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to