On Fri, Nov 01, 2019 at 09:39:29AM -0700, Gregory Rose wrote:
>
> On 11/1/2019 9:36 AM, Simon Horman wrote:
> > On Fri, Nov 01, 2019 at 09:24:08AM -0700, Gregory Rose wrote:
> > > On 11/1/2019 9:20 AM, Simon Horman wrote:
> > > > On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote:
> > > > > On 11/1/2019 8:48 AM, Gregory Rose wrote:
> > > > > > On 11/1/2019 7:50 AM, Simon Horman wrote:
> > > > > > > On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote:
> > > > > > > > On 10/31/2019 2:08 PM, Ben Pfaff wrote:
> > > > > > > > > On Thu, Oct 31, 2019 at 01:30:39PM -0700, Greg Rose wrote:
> > > > > > > > > > When cleaning up unused ipgre code the ipgre_netdev_ops
> > > > > > > > > > structure
> > > > > > > > > > was missed. Get rid of it now.
> > > > > > > > > >
> > > > > > > > > > Fixes: d5822f428814 ("gre: Remove dead ipgre code")
> > > > > > > > > > Signed-off-by: Greg Rose <[email protected]>
> > > > > > > > > Applied to master, thanks!
> > > > > > > > Oh, I guess you didn't see my request to hold off on this. No
> > > > > > > > worries.
> > > > > > > >
> > > > > > > > I'll send a follow up patch with some more code to be excised.
> > > > > > > >
> > > > > > > > And thanks for the quick response!
> > > > > > > This appears to break travis-ci.
> > > > > > >
> > > > > > > https://travis-ci.org/openvswitch/ovs/builds/605766351
> > > > > > OK, it passed here
> > > > > > https://travis-ci.org/gvrose8192/ovs-experimental/builds/605736578
> > > > > >
> > > > > > Let me check what happened.
> > > > > >
> > > > > > - Greg
> > > > > So the patch that got applied yesterday is not the patch that I
> > > > > pushed to
> > > > > test travis. ipgre_tunnel_init and ipgre_xmit
> > > > > also supposed to be deleted. Let's revert the old patch and start
> > > > > over. I
> > > > > have no idea what happened.
> > > > Thanks Greg,
> > > >
> > > > I'm running a revert by travis-ci here:
> > > >
> > > > https://travis-ci.org/horms2/ovs/builds/606077577
> > > Thanks! I'm doing that also. My apologies for the mix up.
> > Thanks, we can race them :)
> >
> > Unfortunately I am still seeing a failure so perhaps the following also
> > needs to be reverted?
> >
> > 42a059e02bf3 ("ip_gre: Remove even more unused code")
>
> Yes, that is the patch that needs reverting. I sent the revert patch
> already, as soon as my travis build passes
> then we should apply it but I'm sure that's the one.
>
> Which patch did you revert?
adf9ac69aee1 ("ip_gre: Removed unused ipgre netdev ops")
> > From a process PoV I think it would be best if you posted
> > a revert patch(es) that someone can apply. Does that work for you?
>
> Yes, agreed.
>
> Thanks,
>
> - Greg
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
