On Fri, Nov 1, 2019 at 3:10 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > > > On 01.11.2019 22:51, William Tu wrote: > > AF_XDP veth does not support TCP with namespaces. This patch skips them. > > > > Signed-off-by: William Tu <u9012...@gmail.com> > > --- > > v1: > > - Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/606194550 > > - make check-afxdp all pass on my machine, but cirrus, it is still > > unstable, > > observe 1 failed at: > > https://cirrus-ci.com/task/6597038589870080 > > --- > > tests/system-afxdp-macros.at | 7 +++++++ > > tests/system-kmod-macros.at | 8 ++++++++ > > tests/system-traffic.at | 18 +++++++++--------- > > tests/system-userspace-macros.at | 8 ++++++++ > > 4 files changed, 32 insertions(+), 9 deletions(-) > > > > diff --git a/tests/system-afxdp-macros.at b/tests/system-afxdp-macros.at > > index f0683c0a901b..27c220998355 100644 > > --- a/tests/system-afxdp-macros.at > > +++ b/tests/system-afxdp-macros.at > > @@ -37,3 +37,10 @@ m4_define([CONFIGURE_VETH_OFFLOADS], > > # > > m4_define([OVS_START_L7], > > [AT_SKIP_IF([:])]) > > + > > +# OVS_CHECK_NC() > > +# > > +# Check if comman nc is available. Always skip because > > +# AF_XDP veth does not support TCP with namespaces. > > +m4_define([OVS_CHECK_NC], > > + [AT_SKIP_IF([:])]) > > Most of the tests uses 'nc -u' generating UDP traffic and works fine. > We should not skip them. There are only 2 tests that are failing now. > Both uses 'nc' without '-u' option, i.e. generates TCP traffic. > Only these tests should be skipped.
OK, thanks. In this case, I'm thinking about adding a new macro, ex: OVS_SKIP_AFXDP in all tests at system-traffic.at that use TCP with nc. Regards, William _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
