On 11/19/2019 7:46 PM, Ilya Maximets wrote:
> On 19.11.2019 18:29, Eli Britstein wrote:
>> On 11/19/2019 7:27 PM, Eli Britstein wrote:
>>> Hi
>>>
>>> I see this file has many inconsistencies against the one from DPDK
>>> (18.11.2).
>>>
>>> For example, this API:
>>>
>>> rte_flow_query(uint16_t port_id,
>>> struct rte_flow *flow,
>>> enum rte_flow_action_type action,
>>> void *data,
>>> struct rte_flow_error *error);
>>>
>>> is wrong, vs the one from DPDK:
>>>
>>> rte_flow_query(uint16_t port_id,
>>> struct rte_flow *flow,
>>> const struct rte_flow_action *action,
>>> void *data,
>>> struct rte_flow_error *error);
>>>
>>> Note the "action" argument.
>>>
>>>
>>> I also see in it this line:
>>>
>>> #error "Use this header only with sparse. It is not a correct
>>> implementation."
>>>
>>>
>>> So, is it wrong on purpose? If so, why?
>>>
>>> I test my patch-set before I submit using travis, and it fails because
>>> of this wrong file. Can we just take the correct code from DPDK?
>>> Should I maybe take only the parts that cause me to fail?
> Hi. DPDK headers before 18.11.3 has issues that makes sparse unhappy.
> This header will be removed along with upgrade to 18.11.3 or higher.
> Right now we're not experiencing issues with current version of
> sparse header probably just because we're not using most of the functions.
I see. Thanks.
>
> We're not going to update this header only remove. You may update it in
> your patches or base your changes on top of dpdk-latest branch where this
> header already removed.
So, what is the preferred way for submission?
1. cherry-pick those commits from dpdk-latest on top of master and my
patches on top of that
2. submit directly on dpdk-latest
>
> I'm not sure when we're going to migrate to 18.11.{3,5}.
> @Ian, @Kevin, is validation still in progress? Does anyone work on this?
Is it a question of "if" or "when"? what is the purpose of migrating to
18.11.3/5 and not to 19.11 soon?
>
> Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
