On Thu, Nov 21, 2019 at 02:58:31PM +0100, Ilya Maximets wrote: > 'ol_flags' of DPDK mbuf could contain bits responsible for external > or indirect buffers which are not actually offload flags in a common > sense. Clearing/copying of these flags could lead to memory leaks of > external memory chunks and crashes due to access to wrong memory. > > OVS should not clear these flags while resetting offloads and also > should not copy them to the newly allocated packets. > > This change is required to support DPDK 19.11, as some drivers may > return mbufs with these flags set. However, it might be good to do > the same for DPDK 18.11, because these flags are present and should > be taken into account. > > Signed-off-by: Ilya Maximets <[email protected]>
This seems reasonable to me, but I don't have much context. With that in mind: Acked-by: Ben Pfaff <[email protected]> I don't usually like "negative" names for things, like the "non-" infix, but it seems appropriate in this case. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
