On 2019-12-03 12:47 AM, Ben Pfaff wrote:
> On Sun, Nov 03, 2019 at 11:11:53AM +0200, Roi Dayan wrote:
>> From: Dmytro Linkin <[email protected]>
>>
>> Currently ofproto design disallow duplicating output packet on forwarding
>> and mirroring to/from same ovs port. Next scenario reveal lack of design:
>> 1. Send ping between regular ovs ports (VFs, for ex.), stop it.
>> 2. While rule still exist, make mirror for one of the ports.
>> Prevent duplicating of traffic to a mirror port.
>>
>> Fixes: 86e2dcddce85 ("dpif-xlate: Snoop multicast packets and send them
>> properly")
>> Signed-off-by: Dmytro Linkin <[email protected]>
>> Acked-by: Roi Dayan <[email protected]>
>
> Thanks for the patch!
>
> I don't think that the following message is correct, because the tests
> here are not concerned with the input port. I think that this message
> should be dropped:
>> + if (ctx->xin->packet != NULL) {
>> + xlate_report_error(ctx, "dropping packet received on
>> port %s, "
>> + "which is reserved exclusively for
>> mirroring",
>> + mac_xbundle->name);
>> + }
>
> This one might better be phrased as "learned port" rather than "output
> port":
>
>> + xlate_report(ctx, OFT_WARN,
>> + "output port is a mirror port, dropping");
>> + return;
>> + }
>
> Thanks,
>
> Ben.
>
ok thanks. we'll send v2.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
