On Thu, Dec 05, 2019 at 05:41:45AM -0800, William Tu wrote: > One question I have in this patch is whether to increase FLOW_WC_SEQ. > And what's the purpose of this number? > > /* This sequence number should be incremented whenever anything involving > flows > * or the wildcarding of flows changes. This will cause build assertion > * failures in places which likely need to be updated. */ > #define FLOW_WC_SEQ 41 > > In this patch, the struct flow_tnl is modified but size does not increase, > so build assertion is passed.
The purpose is to trigger build assertions in all the places that are likely to require updates when a new field is added. The change in size is just a way to trigger a reminder to update FLOW_WC_SEQ; not all new fields change the size, but many new fields do. I recommend incrementing it, because the updates to the build assertions throughout the tree also help with review. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
