On Thu, Dec 19, 2019 at 04:57:37PM +0200, Paul Blakey wrote:
> Each recirculation id will create a tc chain, and we translate
> the recirculation action to a tc goto chain action.
> 
> We check for kernel support for this by probing OvS Datapath for the
> tc recirc id sharing feature. If supported, we can offload rules
> that match on recirc_id, and recirculation action safely.
> 
> Signed-off-by: Paul Blakey <[email protected]>
> Reviewed-by: Roi Dayan <[email protected]>

...

> @@ -1427,6 +1443,11 @@ netdev_tc_flow_put(struct netdev *netdev, struct match 
> *match,
>          }
>      }
>  
> +    if ((chain || recirc_act) && !info.recirc_id_shared_with_tc) {

Hi Paul,

Travis is a reporting an error on this line, pehaps 'info.' should be 'info->' ?

https://travis-ci.org/horms2/ovs/jobs/627292953#L1391

> +        VLOG_ERR_RL(&error_rl, "flow_put: recirc_id sharing not supported");
> +        return EOPNOTSUPP;
> +    }
> +
>      if (get_ufid_tc_mapping(ufid, &id) == 0) {
>          VLOG_DBG_RL(&rl, "updating old handle: %d prio: %d",
>                      id.handle, id.prio);
>  

...
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to