Thanks Ben for the review. Sorry for the delay! On Thu, Nov 21, 2019 at 4:54 PM Ben Pfaff <b...@ovn.org> wrote:
> On Tue, Nov 12, 2019 at 12:47:58AM -0800, amgin...@gmail.com wrote: > > -./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \ > > +if [ $KERNEL_VERSION == "host" ]; then > > Supporting == in [] or "test" is a GNUism. Use = for wider support > (including BSD). > Sure. Sent v2 https://patchwork.ozlabs.org/patch/1213844/ to address both the comments . PTAL. > > > + ./configure --localstatedir="/var" --sysconfdir="/etc" > --prefix="/usr" \ > > +--enable-ssl > > +else > > + ./configure --localstatedir="/var" --sysconfdir="/etc" > --prefix="/usr" \ > > --with-linux=/lib/modules/$KERNEL_VERSION/build --enable-ssl > > +fi > > There's a lot of duplication above, I'd suggest using variables to > reduce the duplication. > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
