On Mon, Dec 23, 2019 at 2:37 AM Yunxiang Tao < [email protected]> wrote: > > Currently, qos can only be deleted by indirect way which must designate > switch or more parameters. The first patch add "name" column to QoS table, > and make QoS table could be listed by "name" witch comand > "ovn-nbctl list qos "name"". > > The second patch change the original "qos-del" to "ls-qos-del", add > a new "qos-del" command. By the new command, you can delete qos > by uuid or name of the qos. It is useful. For example, we can associate > the qos table in neutron and OVN by "name" of qos in OVN, so neutron > could find and easily delete the corresponding qos in OVN. >
Thanks for the patch. I have below comments: 1. There are other ways to associate QoS between Neutron and OVN. For example, the external-ids column can be used to add any customized key-value pairs, such as external_ids:neutron:qos_name = <neutron qos name>. Is this sufficient for your use case? 2. If we believe it is useful for qos-del command to delete qos by name/uuid, it is better to extend the exist command "qos-del" to handle both old and new formats, and we should NOT rename the existing command because it will break existing customer tools. 3. It is more efficient to specify the lswitch in the qos-del command so that it doesn't need to iterate every lswitch. Is there a use case that neutron needs to delete a QoS record without knowing which lswitch should it be deleted from? 4. QoS and ACL are implemented in similar way with similar principles. If "name" is needed in QoS table, probably it is also needed in ACL table. In other words, if we can handle ACL well without introducing the "name" column, probably we could do the same for QoS table without problem. What's your thought on this? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
