Bleep bloop.  Greetings Tonghao Zhang, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#223 FILE: lib/netdev-offload-dpdk.c:391:
    

WARNING: Line has trailing whitespace
#234 FILE: lib/netdev-offload-dpdk.c:402:
#define DPDK_METER_UPATE_UP 65536 

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#248 FILE: lib/netdev-offload-dpdk.c:416:
    

WARNING: Line is 81 characters long (recommended limit is 79)
#277 FILE: lib/netdev-offload-dpdk.c:445:
        VLOG_ERR("rte_mtr_meter_profile_update fail: err_type: %d err_msg: 
%s\n",

WARNING: Line is 81 characters long (recommended limit is 79)
#288 FILE: lib/netdev-offload-dpdk.c:456:
        VLOG_ERR("rte_mtr_meter_profile_update fail: err_type: %d err_msg: 
%s\n",

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#313 FILE: lib/netdev-offload-dpdk.c:481:
    

ERROR: Inappropriate spacing in pointer declaration
#333 FILE: lib/netdev-offload-dpdk.c:501:
    mp.srtcm_rfc2697.cir = max_rate *1024 /8; /* rate_max Kbps*/

WARNING: Line is 90 characters long (recommended limit is 79)
#340 FILE: lib/netdev-offload-dpdk.c:508:
        VLOG_ERR("rte_mtr_meter_profile_add fail: err_type: %d err_msg: %s, 
portid: %d\n",

WARNING: Line is 86 characters long (recommended limit is 79)
#341 FILE: lib/netdev-offload-dpdk.c:509:
                   mtr_error.type, mtr_error.message, 
netdev_dpdk_get_portid(netdev));

WARNING: Line is 86 characters long (recommended limit is 79)
#360 FILE: lib/netdev-offload-dpdk.c:528:
                   mtr_error.type, mtr_error.message, 
netdev_dpdk_get_portid(netdev));

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#365 FILE: lib/netdev-offload-dpdk.c:533:
    

WARNING: Line is 86 characters long (recommended limit is 79)
#380 FILE: lib/netdev-offload-dpdk.c:548:
netdev_offload_dpdk_meter_conf(struct dpif *dpif, struct netdev *netdev, 
uint32_t mid)

WARNING: Line is 86 characters long (recommended limit is 79)
#449 FILE: lib/netdev-offload-dpdk.c:755:
        VLOG_INFO("%s: skip flow offload without actions\n", 
netdev_get_name(netdev));

Lines checked: 531, Warnings: 16, Errors: 1


Please check this out.  If you feel there has been an error, please email 
[email protected]

Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to